Repository navigation
Conversation
…test so it does not depend on test order
Contributor
Author
Thayorns
marked this pull request as draft
October 5, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_areas_merges_defaults_and_pmp_facts_without_duplicatescalledFbe.pmp(fb:, global: {})and leftoptions:andloog:to the$optionsand$loogglobals. Those are set only by other tests in the same process, so whenever the random seed ran this test first,Fbe.pmpraisedThe $options is not set. That is how #1000 went red on a change that never touchespmp.The call now passes
options: Judges::Options.newandloog: Loog::NULL, liketest_refuses_a_missing_contextin the same file, so the test no longer depends on what ran before it, andpickscan run the file alone.CI here will still fail on the master breakage that #1288 fixes, until that one is merged.
Closes #1444