Skip to content

Pass explicit options and loog to the pmp areas test so it does not depend on test order - #1445

Draft
Thayorns wants to merge 1 commit into
zerocracy:masterfrom
Thayorns:1444
Draft

Thayorns wants to merge 1 commit into
zerocracy:masterfrom
Thayorns:1444

Conversation

@Thayorns

@Thayorns Thayorns commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

test_areas_merges_defaults_and_pmp_facts_without_duplicates called Fbe.pmp(fb:, global: {}) and left options: and loog: to the $options and $loog globals. Those are set only by other tests in the same process, so whenever the random seed ran this test first, Fbe.pmp raised The $options is not set. That is how #1000 went red on a change that never touches pmp.

The call now passes options: Judges::Options.new and loog: Loog::NULL, like test_refuses_a_missing_context in the same file, so the test no longer depends on what ran before it, and picks can run the file alone.

CI here will still fail on the master breakage that #1288 fixes, until that one is merged.

Closes #1444

@Thayorns

Thayorns commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@yegor256 this removes the test order flake that broke #1000, happy to clarify anything about it.

@Thayorns
Thayorns marked this pull request as draft October 5, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test of Fbe.pmp areas depends on test order in test/fbe/test_pmp.rb

1 participant