Skip to content

#1425: unwrap the PMP levels in bylaws, so anger, love and paranoia from Fbe.pmp are accepted - #1455

Open
jack5505 wants to merge 1 commit into
zerocracy:masterfrom
jack5505:1425
Open

jack5505 wants to merge 1 commit into
zerocracy:masterfrom
jack5505:1425

Conversation

@jack5505

@jack5505 jack5505 commented Oct 8, 2026

Copy link
Copy Markdown

Fbe.pmp returns an int property wrapped in a SimpleDelegator, while Fbe.bylaws checked anger, love and paranoia with is_a?(Integer), which a delegator doesn't pass. So Fbe.bylaws(anger: pmp.hr.anger, ...) failed with The 'anger' must be an Integer: 2, although the value is an Integer inside.

Fbe.bylaws now unwraps a Delegator before the checks, so the levels from the PMP are accepted as they come. Anything else that is not an Integer, like '2' or nil, is still refused.

Added a test that reads non-default levels from PMP facts and passes them to Fbe.bylaws directly; it fails with the error above without the fix.

Closes #1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fbe.bylaws refuses the anger, love and paranoia that Fbe.pmp returns, saying "must be an Integer: 2"

1 participant