Repository navigation
Conversation
… checked against the search quota
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The off-quota guard of
Fbe.octosends a method to the search-quota check only when its name is inFbe::SEARCH_METHODS. Octokit hassearch_reposas an alias ofsearch_repositories, and the interceptor sees the name the caller used, so with the search quota at zerosearch_repositorieswas stopped whilesearch_reposwent to GitHub and got a 403 back.Added
search_repostoFbe::SEARCH_METHODS; it is the only alias inoctokit/client/search.rb. Added a test that callssearch_reposwith the search quota exhausted and expectsFbe::OffQuotaon the search resource; it fails without the fix.Closes #1433