Repository navigation
Conversation
…rough the off-quota guard, they only read /rate_limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The off-quota guard of
Fbe.octolets the quota calls through by name, but the list had onlyrate_limitandrate_limit!. Octokit also hasrate_limit_remaining,rate_limit_remaining!and the aliasesratelimit,ratelimit!,ratelimit_remaining,ratelimit_remaining!(octokit/client/rate_limit.rb), and once the quota was low they raisedFbe::OffQuotainstead of answering, although they only read/rate_limit, which does not spend the quota.Added all six to the list. Added a test that calls each of them while off-quota and expects the remaining quota back; it fails without the fix.
Closes #1434