Repository navigation
Conversation
…ory from its resolved name
Contributor
Author
|
@yegor256 take a look please, happy to clarify anything about the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fbe::FakeOctokit#repositorytakes a name or a numeric id, and resolves the id to afull_name. It then builtowner,html_urlandurlfrom the raw argument, not the resolved name. Sorepository(1439)claimedfull_name: "zerocracy/baza"andowner.login: "1439"in the same hash, withhtml_urlpointing athttps://github.com/1439. Separately,urlused the HTML host, while GitHub answers withhttps://api.github.com/repos/<full_name>.All three now come from the resolved
repo, as the issue suggests.The new tests check, for the id form, that the owner is the one in
full_nameand thathtml_urlandurlare built fromfull_name. For the name form, a non-ASCII name gets an APIurland keeps its owner.Closes #693