Repository navigation
Conversation
Contributor
Author
|
This duplicates the existing fix in #1360, which validates the operand count of if in both calculation and bylaw rendering along with the other fixed-arity expressions. Keeping that existing PR avoids competing fixes for the same behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1465.
The bill evaluator rejected an
ifterm only when it had fewer than three operands. Additional operands were discarded, and the bylaw formatter performed no arity check at all. A malformed rule could therefore produce a payment and description that omitted part of the supplied expression.Both paths now require exactly three operands and report the number supplied when that requirement is not met. Correct conditionals keep their existing calculation and formatting behavior.
The regression covers zero, one, two and four operands through both billing and bylaw generation. The award, award-logic and between tests passed: 28 tests, 120 assertions. RuboCop passed for both changed files using rubocop-elegant 0.5.1 from the lockfile, and
git diff --checkpassed.