Repository navigation
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1464.
Custom area names were interpolated into both XPath and Factbase expressions. An apostrophe could break the XML lookup before the property query, and quotes or backslashes could also change how the Factbase parser read the area value.
The XML lookup now binds its area name as an XPath variable. Factbase queries bind
$areathrough their parameter context, and property listing uses that same bound enumeration. No area-name characters need to be interpreted as query syntax.The regression reads values and property lists for custom areas containing an apostrophe, a double quote and a backslash, and checks that those names remain present in
areas. The PMP tests passed: 24 tests, 57 assertions. RuboCop passed for both changed files with the lockfile's rubocop-elegant 0.5.1, andgit diff --checkpassed.