judges/who-is-alive/who-is-alive.rb:27 has next if seen.include?(f.who), so each user is checked once per run no matter how many facts carry their id.
Each time I replaced the line with nil, ran the judge's YAML packs (judges test --judge <name> judges) and its test file under test/judges/, and everything stayed green.
Without it the judge asks GitHub once per fact, which is the difference between a few calls and thousands.
What should happen: a test with several facts of the same user expects one user call to GitHub.
judges/who-is-alive/who-is-alive.rb:27hasnext if seen.include?(f.who), so each user is checked once per run no matter how many facts carry their id.Each time I replaced the line with
nil, ran the judge's YAML packs (judges test --judge <name> judges) and its test file undertest/judges/, and everything stayed green.Without it the judge asks GitHub once per fact, which is the difference between a few calls and thousands.
What should happen: a test with several facts of the same user expects one
usercall to GitHub.