Repository navigation
Conversation
Contributor
Author
# Conflicts: # judges/latest-assessment/latest-assessment.rb # test/pages/test_latest_assessment.rb
Contributor
Author
|
@yegor256 I merged the current master and kept the earliest-timestamp comparison. All required CI checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The judge used Fact#when both to compare assessments and to populate the summary. That accessor exposes only the first value of a multi-valued property, while the page's z:when helper defines the effective timestamp as the earliest value. The summary could therefore select an assessment that is not actually latest.
The judge now compares assessments by the minimum value in each when property and stores that same effective timestamp.
Checks: the regression case in TestLatestAssessment#test_uses_earliest_value_when_comparing_multi_valued_dates and the repository's Ruby CI suite.
Closes #950