Repository navigation
#939: sort award rows by their group totals - #955
Merged
Merged
Conversation
Contributor
Author
Member
|
@gemshrine thanks for the fix, merged. Generated by Claude Code |
|
@gemshrine Thanks for your contribution! 🎉 You've earned +20 points (+24 base, -4 for a smaller hits-of-code count of 20). Keep up the momentum—quality over speed always wins! Your running score is now +6738, and don't forget to check your Zerocracy account for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The awards table groups facts by programmer but sorted each row using only the group-leading fact's award. A programmer with several awards could therefore appear below someone whose total was smaller.
The sort key now sums award values across current-group(), matching the total shown in the Run column. The regression case gives one programmer awards of 1 and 100 and another an award of 50, then checks the row order.
Checks: TestAwards#test_sorts_programmers_by_their_total_awards and the repository's Ruby/XSLT CI suite.
Closes #939