Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action accepted token option keys case-insensitively, but the log-masking and token-detection code only matched the lowercase spelling. With verbose logging, an uppercase GITHUB_TOKEN option could bypass masking and also be treated as absent.
The option key is now normalized before masking and token detection. Tracing stays disabled while the option is inspected, and the token value is registered with the Actions log masker before later commands can expand it.
Checks: Bash syntax validation and the entry.sh option-parsing scenario with verbose mode and an uppercase GITHUB_TOKEN key.
Closes #941