Skip to content

#920: validate today before updating the factbase - #961

Open
gemshrine wants to merge 1 commit into
zerocracy:masterfrom
gemshrine:920
Open

gemshrine wants to merge 1 commit into
zerocracy:masterfrom
gemshrine:920

Conversation

@gemshrine

Copy link
Copy Markdown
Contributor

The today input was checked only for its character pattern. Impossible dates such as February 30 and out-of-range timezone offsets passed the check, so the action could run judges and spend API quota before XSLT rejected the value.

The entry script now validates the calendar and time with Ruby's ISO-8601 parser and enforces the XML Schema timezone limit of -14:00 through +14:00 before updating the factbase.

Checks: Bash syntax validation and entry-script scenarios for an impossible calendar date and timezone offsets beyond the supported range.

Closes #920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An impossible today date passes validation and fails during rendering

1 participant