Repository navigation
Conversation
Member
|
@yegor256 this regroups the whole awards table by account id with many touched xpaths in awards.xsl, and it will likely conflict with other awards.xsl changes. Needs a human look. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Awards for one GitHub account could be split into separate rows after a login change because the table grouped by who_name. Reconciliation lookup used that mutable login too, so an existing payout snapshot under the old login was not applied to awards under the new one.
The table now groups and calculates totals by the stable who ID, resolves the latest known login from who-has-name facts for display, and matches reconciliation facts by that ID. Name-based grouping remains as a fallback for facts without a who ID.
Checks: TestAwards#test_groups_awards_by_user_id_and_shows_latest_login and the repository's Ruby/XSLT CI suite. The regression scenario includes old and new logins, awards under both names, and a reconciliation under the old name.
Closes #942