Skip to content

#825: Align badge statistics with running balance period - #963

Open
gemshrine wants to merge 3 commits into
zerocracy:masterfrom
gemshrine:825
Open

gemshrine wants to merge 3 commits into
zerocracy:masterfrom
gemshrine:825

Conversation

@gemshrine

Copy link
Copy Markdown
Contributor

Fixes #825.

The badge and page descriptions currently calculate the average and total over a fixed 256-day window using all award facts. The awards table uses days_of_running_balance (default 28) and filters to human awards, so readers can see different totals for the same report.

The badge and descriptions now use the same pmp/hr running balance period and human award facts as the table. The shared z:pmp function moved into xsl/pmp.xsl so both XSL transforms read the same setting and fallback.

Regression coverage adds a seven-day factbase with one recent human award, one older human award, and a recent non-human award. The badge and both page descriptions are checked against that set; the existing badge decimal fixture stays within the default period and marks its awards as human.

The repository's GitHub CI runs the Ruby tests and XSL transformations, including the new fixtures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent award data display due to mismatched time period configurations

1 participant