Repository navigation
Conversation
Contributor
Author
Contributor
Author
|
@yegor256 I updated the branch with current master. The make check and all other CI checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #817.
The entry script currently exports YAML, XML, JSON, and HTML before running
judges update. The update can add or refresh derived facts, and the later rich XML used by the vitals page is already generated after that update. Downloads can therefore show an older factbase than the page.Move the four downloadable exports after the update so every format and the vitals page use the same factbase state.
The regression fixture seeds older and newer assessment facts, runs the entry script so the
latest-assessmentjudge creates its summary, and checks that the summary appears in YAML, XML, JSON, and HTML.Checks
make, includingentries/exports-updated-factbase.sh