Skip to content

Makefile does not rebuild PDFs when pitch.cls changes #39

Description

@gemshrine

What is wrong?

The pattern rule for both PDFs declares only the .tex file as a prerequisite. Changes to pitch.cls, which contains the shared document class and most of the deck's formatting and package setup, do not make sales-deck.pdf or founder-pitch.pdf out of date. CI can therefore publish PDFs rendered with an older class.

Where?

Makefile:11-12

Reproduction

  1. Build the repository once with make.
  2. Change a visible definition in pitch.cls (for example, alter \renewcommand\emph or the page color).
  3. Run make again without deleting the PDFs.
  4. Make reports both targets up to date and leaves the PDFs byte-for-byte unchanged.

Expected behavior

Changing a shared class used by both documents should trigger regeneration of both PDFs.

Suggested fix

Add pitch.cls (and any other shared generated/input assets) as a prerequisite of the pattern rule, or use explicit targets with complete dependency lists.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions