Skip to content

Makefile ignores image assets used by sales-deck.tex #40

Description

@gemshrine

What is wrong?

The PDF pattern rule depends only on each .tex file, although sales-deck.tex embeds vitals.png, comment.png, several PDF icons, and the downloaded logo.svg. Updating any of these assets does not rebuild sales-deck.pdf; CI can deploy a PDF containing old screenshots or icons.

Where?

  • Makefile:11-12
  • sales-deck.tex:9-10,18,31,46,83-87

Reproduction

  1. Run make once.
  2. Replace vitals.png or comment.png with a visibly different image.
  3. Run make again without deleting sales-deck.pdf.
  4. Make considers the target up to date and the PDF still contains the previous image.

Expected behavior

Changing an embedded image should invalidate and regenerate the PDF.

Suggested fix

List every local image (and the generated logo.svg) as prerequisites of sales-deck.pdf, or generate a complete dependency file from LaTeX so all included assets are tracked.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions