Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295.
The entrypoint currently exits with
invalid argument: --summary --max-cycles=3before running any judge. Pass--summary=addso each job runs and writes a fresh summary.Add a regression that invokes the actual entrypoint with a temporary factbase, then verifies that the sample judge added
helloand that one summary fact exists. It fails with exit 64 on the original command and passes with the fix.Validation: full
bundle exec rakeon Ruby 3.4.9, using locked Judges 0.58.1 and FBE 0.47.0: 4 tests, 21 assertions, no failures/errors/skips; the judge fixture and RuboCop pass. Tests ran in a Docker container with networking disabled;bash -n entry.shalso passes. No dependency changes.CI: 9 checks pass, including Ruby 3.4.9
rakeand ShellCheck.markdown-lintreports the same ten errors in the unchanged README already tracked by #283 and addressed by existing PR #290. The base revision's run 27460713002 also failed. This PR does not change README or the lint workflow.