Repository navigation
#142: preserve MIME type in product resource reads - #149
Open
williamleewilliam1-star wants to merge 1 commit into
Open
williamleewilliam1-star wants to merge 1 commit into
williamleewilliam1-star wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product resources advertise
text/plaininresources/listbut omit it fromresources/read. Return the same MIME type with the resource content so clients retain the advertised format.The regression test lists resources, reads one using its advertised URI, and checks the URI, text and MIME type together. It fails on the unchanged source because
mimeTypeis missing.Closes #142.
Validation:
make test lint tsc: passed; 22 tests.tools/listwith--clibefore--config: passed.make itcommand remains blocked by the pre-existing argument-order issue make it fails on master because --cli stands after --server in the inspector call #123 (already addressed separately by PR #123: put --cli in front of the inspector arguments #124).AI-assisted contribution; the regression failure and verification commands were executed locally.