Drop the system-setup route: its controller was never written - #2
Merged
Conversation
The route pointed at Zerp\Hrm\Http\Controllers\SystemSetupController, which does not exist. Laravel resolves controllers lazily, so this stayed quiet until something walked the route table: artisan route:list threw a ReflectionException, and /hrm/system-setup 500'd. Nothing links to it and there is no SystemSetup/Index page to render. The system setup screens are all reachable through their own routes (hrm.branches.index and friends), so the route is dead and goes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/Routes/web.phpregisteredhrm.system-setup.indexagainstZerp\Hrm\Http\Controllers\SystemSetupController— a class that does not exist anywhere in the package.Laravel resolves controllers lazily, so this stayed quiet until something walked the whole route table:
php artisan route:listthrewReflectionException: Class "Zerp\Hrm\Http\Controllers\SystemSetupController" does not exist/hrm/system-setupwould 500 in productionNothing links to the route, and there is no
Hrm/SystemSetup/Indexpage for it to render — the system-setup screens each have their own routes (hrm.branches.indexand friends) and shareSystemSetupSidebar.tsx. So the route is dead weight, and it goes.Verified:
artisan route:listnow completes, 227 hrm routes listed.Pre-existing on
master; not introduced by the tenant-scope work.