add field hard deletion and update test for field deletion#79
Open
mattezra wants to merge 2 commits into
Open
Conversation
shrunyan
requested changes
May 13, 2026
| } | ||
|
|
||
| async deleteModelField(modelZUID, fieldZUID) { | ||
| async deleteModelField(modelZUID, fieldZUID, hardDelete = "false") { |
Contributor
There was a problem hiding this comment.
While ultimately this value will end up as a string in the URL. The sdk interface of it being a string is awkward.
It would not be normal to program this;
deleteModelField("6-000-0000", "12-000-0000", "true")Where as this would be;
deleteModelField("6-000-0000", "12-000-0000", true)The consuming developer should be able to author a boolean value. You need to handle that ending up as the correct value going into the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
This PR adds support for field hard deletion as this is already supported (see docs) using the
hardDeletequery param.This PR also adds back field deletion in the test suite as the field will now be hard deleted in the database, to prevent the
Row size too largedatabase error encountered when a lot of fields are created for a model (a new field creates a new column in the model record).