[co-3778] refactor: unified advanced filter modals tests#1245
Draft
FrancescoGottardi wants to merge 1 commit into
Draft
[co-3778] refactor: unified advanced filter modals tests#1245FrancescoGottardi wants to merge 1 commit into
FrancescoGottardi wants to merge 1 commit into
Conversation
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors and consolidates the AdvancedFilterModal test suite, removing the previous split “pt2” test file and simplifying test utilities to rely on the modal’s internal react-hook-form setup.
Changes:
- Simplified shared test utilities by removing the custom
FormProvider/useFormwrapper and related default-values helpers. - Consolidated and reorganized AdvancedFilterModal tests into clearer
describeblocks with parameterized cases. - Deleted
advanced-filter-modal-pt2.test.tsxafter migrating its coverage into the main test file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/views/search/test/test-advanced-filter-modal-common-utils.tsx | Removed obsolete form-wrapper utilities; kept only defaultProps. |
| src/views/search/test/advanced-filter-modal.test.tsx | Unified/restructured modal tests; added useContactInput mocking and migrated pt2 assertions. |
| src/views/search/test/advanced-filter-modal-pt2.test.tsx | Removed redundant split test file after consolidation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+475
to
+486
| await user.click(screen.getByRole('button', { name: /action\.search/i })); | ||
| expect(onSearchConfirm).toHaveBeenCalledWith( | ||
| expect.objectContaining({ includeSharedFolders: true }) | ||
| ); | ||
| rerender(<AdvancedFilterModal {...props} />); | ||
| await waitFor(() => { | ||
| expect( | ||
| within(screen.getByTestId('isSharedFolderIncludedToggle')).getByTestId( | ||
| 'icon: ToggleRight' | ||
| ) | ||
| ).toBeInTheDocument(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.