Changed root_key to NULL in CancelOrder service description to match … - #70
Open
tseven wants to merge 1 commit into
Open
Changed root_key to NULL in CancelOrder service description to match …#70tseven wants to merge 1 commit into
tseven wants to merge 1 commit into
Conversation
…what the Shopify API expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…what the Shopify API expects.
I feel this was the cleanest most simple way to fix this inconsistency.
Since Shopify's response for canceling an order contains additional information outside the 'order' parameter, I felt it's best to leave it in.
IE, the order cancel response contains "notice" along with a message of success or not.
This would be lost if we were to unwrap the response.