Use witdh 1 for special chars when slipping strings#424
Conversation
|
Sorry, I had to reopen this PR due to a bad command with the previous one. |
fff4e78 to
0b06f8c
Compare
0b06f8c to
01dd80d
Compare
|
Getting back to this; I am sure, But I am not sure whether it's the right fix. If it would be free but this I guess this issue must be solved on the architecture level --- somehow --- 🤔 💭 Just left some thoughts here. Have a great weekend and appreciate your work. |
|
Maybe like having a DIRTY marker to indicate that we shall do some processing beforehand. |
|
But I mean it's all in regard that it'd be ideal to not pay for what is not used in most cases. Just thoughts outloud |
|
@zhiburt, I totally agree that this is probably a very dirty approach to solving this issue. I opened this PR more to raise the problem than proposing a real solution. On the other side, knowing if a header contains or not a break line or a TAB char can be difficult, especially if the value is loaded at runtime. Having a flag can be a solution but I feel it is dirtier than the fix itself 😄 |
A naive attempt to fix issue #410
The PR adds 1 to the width of a string when a special char is encountered.