Pinned stomp to <9 again; Other improvements for stomp - #2279
Open
andy-maier wants to merge 1 commit into
Open
andy-maier wants to merge 1 commit into
andy-maier wants to merge 1 commit into
Conversation
andy-maier
force-pushed
the
andy/stomp-pin-improve
branch
from
September 12, 2026 11:17
60d969e to
65f4316
Compare
Details: * Changed pinning of stomp.py from <8.3.0 to <9.0.0. The 8.3.0 version is meanwhile yanked, but the changes in version 9.0.0 have not yet been accommodated in zhmcclient. * In preparation of future stomp version 9 support, added explicit enabling or disabling of certificate validation with stomp, in the NotificationReceiver and AutoUpdater classes. * To check the stomp version, added a new parse_version() function to the zhmcclient._utils module that translates the stomp version string into a tuple of int values. Added unit test cases for parse_version(). * The AutoUpdater.open() method has been changed to no longer raise stomp exceptions directly. Such exceptions are now raised as zhmcclient.NotificationConnectionError. Added an incompatibility change log entry about that change. The other class that connects to stomp, NotificationReceiver already raises stomp exceptions as zhmcclient.NotificationConnectionError, so this is now consistent. * Added logging before opening and closing the JMS (stomp) connection in the zhmcclient auto-update support, to provide context for any errors logged during opening and closing the connection. Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/stomp-pin-improve
branch
from
September 12, 2026 11:33
65f4316 to
f65d2fe
Compare
Collaborator
|
coverage: 78.839% (-0.03%) from 78.865% — andy/stomp-pin-improve into master |
andy-maier
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
I tested this with the test_auto_update.py end2end test against the HMC of B151.
The remaining issues with stomp version 9 are documented in https://codeberg.org/jasonrbriggs/stomp.py/issues/453
Note: After merging this PR, reopen the linked issue again.