Skip ctc partition links in hipersocket adapter delete. - #2289
Merged
Merged
Conversation
Signed-off-by: Simon Spinner <sspinner@de.ibm.com>
Signed-off-by: Simon Spinner <sspinner@de.ibm.com>
simon-spinner
force-pushed
the
simon/hisodelete
branch
from
September 14, 2026 13:38
df43b9b to
8ff4e67
Compare
Signed-off-by: Simon Spinner <sspinner@de.ibm.com>
Signed-off-by: Simon Spinner <sspinner@de.ibm.com>
Signed-off-by: Simon Spinner <sspinner@de.ibm.com>
Collaborator
|
coverage: 78.991% (+0.1%) from 78.865% — simon/hisodelete into master |
andy-maier
approved these changes
Sep 15, 2026
andy-maier
requested changes
Sep 15, 2026
andy-maier
left a comment
andy-maier
left a comment
Member
There was a problem hiding this comment.
Please add a change log file that mentions the bug fix.
The other changes in the PR (improved mock support for PartitionLink.list()) should probably also be mentioned (in a separate change log file).
Signed-off-by: Simon Spinner <sspinner@de.ibm.com>
andy-maier
approved these changes
Sep 15, 2026
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable_1.26
git worktree add -d .worktree/backport-2289-to-stable_1.26 origin/stable_1.26
cd .worktree/backport-2289-to-stable_1.26
git switch --create backport-2289-to-stable_1.26
git cherry-pick -x 939668c752a9132a3cacc26e57c23905f993321c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a
KeyErrorbug that occurred when deleting a Hipersocket adapter on a CPC that also has CTC-type partition links present (issue #2276). CTC partition links do not have anadapter-uriproperty, which caused the deletion logic to fail when attempting to look up that property. The fix skips CTC partition links during the adapter URI comparison.