Skip to content

fix(copymangas): restore Animetail update compatibility - #1

Merged
zhongfly merged 1 commit into
zhongfly:mainfrom
ahe-meow:fix/copymangas-animetail-update
Sep 16, 2026
Merged

zhongfly merged 1 commit into
zhongfly:mainfrom
ahe-meow:fix/copymangas-animetail-update

Conversation

@ahe-meow

@ahe-meow ahe-meow commented Sep 6, 2026

Copy link
Copy Markdown

Summary

  • Restore the interceptor ordering required by Animetail so the uncaught-exception handler runs first and response validation follows it.
  • Add the legacy SManga suspend adapters used by Animetail and preserve them through shrinking.
  • Make manga update handling respect the requested detail/chapter flags and tolerate nullable API fields.

Changes

File Change
src/zh/copymangas/src/eu/kanade/tachiyomi/extension/zh/copymangas/CopyMangas.kt Fix interceptor ordering and Animetail update adapters/flag handling.
src/zh/copymangas/src/eu/kanade/tachiyomi/extension/zh/copymangas/CopyMangasDto.kt Handle nullable manga metadata and chapter groups safely.
src/zh/copymangas/proguard-rules.pro Keep the public legacy suspend adapters from being removed or renamed.
src/zh/copymangas/build.gradle.kts Increment versionCode from 57 to 58.

Validation

  • git diff --check
  • Branch is based directly on upstream main.
  • Manually installed the generated APK and verified the affected Animetail library update flow.
  • ./gradlew :src:zh:copymangas:lintRelease — attempted locally but blocked during Gradle configuration because the available Java 25 installation does not provide JAVA_COMPILER; no source compilation was reached.

Checklist

  • Source name and language are unchanged.
  • versionCode was updated.
  • The changes were manually reviewed after AI assistance.
  • No generated or session files are included.
  • This PR contains one focused work unit.

The upstream repository has Issues disabled, so there is no issue number available to reference.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused compatibility changes are internally consistent and no blocking issues were identified.

Pull request overview

Restores CopyMangas compatibility with Animetail’s legacy update flow while preserving current KeiSource behavior.

Changes:

  • Reorders interceptors for compatible exception handling and response validation.
  • Adds preserved legacy manga/chapter adapters with flag-aware updates.
  • Safely handles nullable metadata and chapter groups.
File summaries
File Description
CopyMangas.kt Adds adapters and corrects update/interceptor behavior.
CopyMangasDto.kt Handles nullable API metadata safely.
proguard-rules.pro Preserves legacy adapter methods during shrinking.
build.gradle.kts Bumps the extension version code.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@zhongfly
zhongfly merged commit 581c2c9 into zhongfly:main Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants