Say where the feed comes from - #209
Merged
Merged
Conversation
The README described the app without mentioning the thing that decides whether anybody you follow is in it. Following somebody does not mean seeing them: if they publish only to relays you are not on, they are absent with nothing to say so, and closing that is most of what the last four changes were about. The performance table was also describing a measurement the script no longer takes. It said "a live feed on an account that follows three hundred people", which was true when it was written and has not been since the harness started seeding its own fixed corpus; the budgets in it were the old ones, so anybody running the script saw a table that disagreed with the numbers on their screen. Now it says what the harness measures, at the budgets the harness enforces, and that a reading only means something against another in the same power state.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README walked through what Plaza looks like, how to install it and how fast it draws, and never mentioned the thing that decides whether the people you follow are in your feed at all.
Adds a section on it: why following somebody does not mean seeing them, what the app does about it, why the relays it connects to are not the popular ones, and what that measured.
And a table that had gone stale
The performance section said its numbers came from "a live feed on an account that follows three hundred people". That was true when it was written. It has not been since
scripts/frame-budget.shstarted seeding a fixed corpus into a store of its own, and the budgets printed in the README were the pre-harness ones, so anybody who ran the script got a table that disagreed with their screen in both columns.Node count corrected too: 330 was the old figure, the harness reports 462.
Also states the thing that makes any of these readable: timings on a shared machine only read high, so the harness takes the best of three rounds and prints the power state, and a reading only means something against another taken in the same state. I have chased a 2.4x regression that was nothing but a busy machine, and would rather the next person did not.