Skip to content

基于milvus sdk java的vector graph rag实现#35

Open
zaojiankongli wants to merge 1 commit into
zilliztech:mainfrom
zaojiankongli:main
Open

基于milvus sdk java的vector graph rag实现#35
zaojiankongli wants to merge 1 commit into
zilliztech:mainfrom
zaojiankongli:main

Conversation

@zaojiankongli

Copy link
Copy Markdown

严格按照你们的逻辑来实现了。本质上是写给自己用的。ai写的。

@zc277584121

Copy link
Copy Markdown
Collaborator

Thanks for the contribution. This is a substantial Java implementation rather than a small patch to the current Python package, so I do not think we can merge it as-is.

A few blockers before this could be considered:

  • The PR includes compiled Maven output under target/, including .class files and maven-status files. Generated build artifacts should not be committed.
  • The Java implementation is added as a separate root-level Maven project, but the repository does not currently have Java SDK packaging, CI, docs, examples, or release flow.
  • There are no tests or parity notes explaining which Python Vector Graph RAG features are covered and which are not.
  • We should first decide whether a Java SDK belongs in this repository or should live as a separate project.

If you want to continue this direction, the next useful step would be to remove generated artifacts, add a README with usage and scope, add tests, and open a design discussion for how the Java package should be maintained and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants