基于milvus sdk java的vector graph rag实现#35
Open
zaojiankongli wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the contribution. This is a substantial Java implementation rather than a small patch to the current Python package, so I do not think we can merge it as-is. A few blockers before this could be considered:
If you want to continue this direction, the next useful step would be to remove generated artifacts, add a README with usage and scope, add tests, and open a design discussion for how the Java package should be maintained and released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
严格按照你们的逻辑来实现了。本质上是写给自己用的。ai写的。