AIP-10027 : Cleaning up resource retry strategy feature - #15
Open
v-abhijeets wants to merge 1 commit into
Open
v-abhijeets wants to merge 1 commit into
v-abhijeets wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
resourceRetryStrategy/DoWithResourceAwareRetrypath addedin AIP-9672. Quota-aware flow control is now fully handled by the JetStream
BackpressureWaiter(AIP-9985, PR #13), so the per-trigger retry mechanismis redundant.
Jira: AIP-10027
Supersedes: AIP-9672
Changes
Removed
common/retry.go:IsResourceConstraintError,DoWithResourceAwareRetrycommon/retry_test.go: tests for the abovepkg/apis/sensor/v1alpha1/types.go:Trigger.ResourceRetryStrategyfieldpkg/apis/sensor/v1alpha1/zz_generated.deepcopy.go: corresponding deepcopysensors/listener.go: switchedactionFuncfromDoWithResourceAwareRetryback toDoWithRetryUnchanged
DoWithRetryremains the single trigger-retry helperBackpressureWaiter,HasCapacity,WaitForCapacity,getBackpressureConfig,setupBackpressure, and theRESOURCE_QUOTA_NAME/BACKPRESSURE_*env-var wiring)Net diff:
+1 / -164across 5 files.Compatibility
resourceRetryStrategywas never published in CRD / OpenAPI / proto /jsonschema / examples, so no external schema or
kubectl applybehaviour changes. No codegen regeneration needed.
resourceRetryStrategyset continue to apply;the field is silently ignored.
retryStrategy(same asany other error). On JetStream sensors with backpressure env vars set,
this is a no-op since backpressure prevents the trigger from running
when quota is full.
Testing
go build ./...andmake testpass locally.and backpressure tests are unchanged.
rg 'resourceRetryStrategy|DoWithResourceAwareRetry|IsResourceConstraintError'.