fix: Adding fix for incorrect archived workflows URL redirecti… - #13
Closed
v-abhijeets wants to merge 1 commit into
Closed
v-abhijeets wants to merge 1 commit into
v-abhijeets wants to merge 1 commit into
Conversation
v-abhijeets
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #AIP-10019
Motivation
With
BASE_HREF=/argo-ui/, the UI built URLs like/argo-ui//archived-workflows/<ns>/<uid>becauseuiUrl/apiUrlnaively concatenated the base href with paths that started with/. Archived-workflow links fromtrain-and-evaluate(job 101830841) redirected to that broken URL.The earlier fix attempt didn't ship: our
.gitlab-ci.ymlonly built--target workflow-controller, but the UI is only compiled and embedded into theargocliimage (used by theargo-serverDeployment).Modifications
ui/src/app/shared/base.ts: addedjoinBasePath(strips trailing/on base, leading/on path, joins with a single/) and routeduiUrl,uiUrlWithParams,apiUrlthrough it. HardenedbaseUrl()to fall back to/when<base href>is missing.ui/src/app/shared/base.test.ts(new): regression tests covering all combinations of trailing/leading slashes, empty paths, and the original/argo-ui//archived-workflowscase..gitlab-ci.yml: parameterized--targetviaDOCKER_TARGET, dropped the redundant host-sidemake dist/workflow-controller, and addedbuild:argo-server(targetargocli, contains the UI) andbuild:argoexecjobs. Existingbuild:workflow-controllerjob keeps theargo-workflowsartifact name for backwards compatibility.Verification
argo-workflows,argo-server,argoexec(allv3.5.6-<slug>).argo-serverDeployment to the newargo-servertagtrain-and-evaluatein sandbox surfaces/argo-ui/archived-workflows/<ns>/<uid>(no//) and resolves correctly.