AIP-10276 : Backward compatibility to generate Argo URL based on Argo WF Controller version - #334
Open
v-abhijeets wants to merge 2 commits into
Open
v-abhijeets wants to merge 2 commits into
v-abhijeets wants to merge 2 commits into
Conversation
…ontroller version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds backward-compatible Argo workflow URL generation for both legacy and modern Argo UI route shapes (AIP-10276, related to AIP-10272).
get_argo_url() now supports two URL formats via ARGO_UI_ROUTE_MODE:
ARGO_UI_ROUTE_MODE=auto (default) probes the Argo UI HTML on ARGO_RUN_URL_PREFIX:
Explicit legacy / modern still override auto-detection.
Testing
Why this change is needed?
The Argo server was migrated so that the workflow UI is now served directly at
https://<argo-server-host>/workflows/...— the legacy/argo-ui/path segmentno longer exists. The CI variables in
.gitlab-ci.ymlwere already updated topoint
ARGO_RUN_URL_PREFIXat the bare host (e.g.https://argo-server.int.sandbox-k8s.zg-aip.net/), soget_argo_url()wasproducing broken links of the form