add check for reorgs to blocks that aren't higher than the current best tip#1178
Open
AloeareV wants to merge 2 commits into
Open
add check for reorgs to blocks that aren't higher than the current best tip#1178AloeareV wants to merge 2 commits into
AloeareV wants to merge 2 commits into
Conversation
AloeareV
force-pushed
the
add_reorg_check_to_sync_loop
branch
from
4f60f22 to
9cda199
Compare
idky137
reviewed
Jun 6, 2026
| working_snapshot: &mut NonfinalizedBlockCacheSnapshot, | ||
| // Callers should provide None. Used for self-recursion case only | ||
| height_to_recurse_to: Option<Height>, | ||
| ) -> Result<(), SyncError> { |
Contributor
There was a problem hiding this comment.
Should this also have the recursion limit as in #1179 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a quick fix, I've added a post-normal-sync check, where we handle reorgs if the chaintip hashes don't match. This couple perhaps fit more elegantly in the sync loop itself.