Conversation
timroes
marked this pull request as ready for review
February 17, 2026 12:03
Collaborator
Author
|
Talked to @Awendel and he'll add a fix for this as part of his PR on working on Selective Editing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a script that'll generate a list of all "starter files", i.e. all files that are included in the starter repository and stops attaching data-zite-id to elements, if the file path would be a starter file, since those are the cases that'll later crash the editor (see https://linear.app/fillout/issue/ZIT-2867/editor-crashes-when-editing-child-element-of-component).
The way we're uploading edited files later, I didn't see a cleaner way to do that, than have that list comitted. However if reviewers know a way of determining without that list later on, if a file is part of the starter files or part of the LLM generated ones, happy to change to a new approach.
Also add a github workflow that makes sure that list is updated in a PR, and otherwise fail the PR (see https://github.com/zite/zitejs-starter/actions/runs/22096567870/job/63855082206 for an example of the failure).