chore(test): belt-and-braces polish on top of #94 - #100
Merged
Conversation
Four small follow-ups identified by the pre-CI audit, none blocking but all worth landing: 1. router.rs: switch `&*PUBLISHER_ADDRESS` deref to `.clone()` — eliminates a llvm-cov region-tracking edge case on the new handler's first line (98% safe either way; this is belt-and- braces). Address::clone is cheap. 2. router_tests.rs: wrap both await points of `mint_handler_concurrent_mint_during_proof_returns_503` in `tokio::time::timeout` (30 s + 60 s). Prevents a future regression in `mint_handler` phase 2 from hanging the 120-min CI job budget. 3. api_remote.rs: replace stale `reset-zkcoins-server` comment references with the post-rename `reset-zkcoins-node`. Cosmetic; matches the host-side dispatcher command name updated in DFXServer/server commit f74ec4a. 4. ci.yaml: the polling-pattern lint step (issue #84 guard) targets paths under `server/src/` that no longer exist after PR #93's rename to `node/src/`. The grep returned empty vacuously, which means the lint has been silently dead for 24 h. Update paths. Note: the audit also flagged the stale `server::create_router` comment in runtime_tests.rs, but that fix already landed in 687f412 on chore/test-quality-overhaul. Stacked on top of PR #94 (chore/test-quality-overhaul) per the "no force-push during running CI" project convention.
TaprootFreak
force-pushed
the
polish/test-quality-followup
branch
from
May 25, 2026 10:39
a9524bc to
4c697d5
Compare
TaprootFreak
marked this pull request as ready for review
May 25, 2026 10:40
TaprootFreak
added
ci:full
TaprootFreak
added
ci:full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #94 (chore/test-quality-overhaul). Five small follow-ups identified by the pre-CI audit — none blocking PR #94, all worth landing.
What
router.rs— switch&*PUBLISHER_ADDRESSderef to.clone(). Eliminates a llvm-cov region-tracking edge case on the new handler. Address clone is cheap; this is belt-and-braces against a 2% risk identified by the pre-CI risk analysis.router_tests.rs— wrap both await points ofmint_handler_concurrent_mint_during_proof_returns_503intokio::time::timeout. Prevents a regression inmint_handlerphase 2 from hanging the 120-min CI budget.api_remote.rs— replace stalereset-zkcoins-servercomment refs withreset-zkcoins-node(post-PR rename: server → node (full identity rename) #93 rename consistency).runtime_tests.rs— staleserver::create_routerreference introduced by the test-quality commit before PR rename: server → node (full identity rename) #93's rename sweep landed. (Already fixed in 687f412 on the base branch — no change needed in this PR.)ci.yaml— the polling-pattern lint step (issue architecture: no polling, events only (scanner Esplora, repo-wide principle) #84 guard) targetsserver/src/*paths that no longer exist after PR rename: server → node (full identity rename) #93's rename tonode/src/*. The grep returned empty vacuously, which means the lint has been silently dead for ~24 h. Update paths.Why stacked instead of pushed to #94
PR #94's Heavy Tests + Coverage Gate were running on the M3 Ultra. Pushing to
chore/test-quality-overhaulwould cancel the in-flight run. The stacked PR pattern matches what we did with PR #90 / #91.Merge plan
Merge PR #94 first (squash). Then this PR's base auto-rebases to
develop(or manually rebase) and can be merged as a separate squash.Test plan