fix(ci): set ZKCOINS_E2E_ALLOW_FEATURE_TRIMMED_SERVER on PRD api-e2e - #114
Merged
TaprootFreak merged 1 commit intoMay 26, 2026
Merged
Conversation
PRD image ships the same MVP-only binary as DEV per Dockerfile policy, but deploy-prd.yaml's api-e2e step was missing the escape-hatch env var that lets feature-gated tests (address-list, lnurl) skip cleanly instead of panicking the CI canary. PR #18 (develop→main auto-release) brought the feature-trimmed-server check from PR #105 to main, and the next PRD deploy (run 26441824314) failed with 4 panics on tests gated by features the MVP build never enables. Mirror deploy-dev.yaml's env block on the PRD api-e2e step.
TaprootFreak
marked this pull request as ready for review
May 26, 2026 08:49
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After PR #18 (develop→main auto-release) merged the feature-trimmed-server check from PR #105 to main, the next Deploy PRD run failed:
address_list_returns_addresseslnurl_pay_callback_returns_phase2_stublnurlp_unknown_user_returns_404username_claim_resolve_lnurlp_roundtripRoot cause
deploy-dev.yamlhas the escape-hatch env var (ZKCOINS_E2E_ALLOW_FEATURE_TRIMMED_SERVER: "true") on its api-e2e step;deploy-prd.yamldid not. Both DEV and PRD ship the MVP-only binary perDockerfilepolicy ("the two environments run the identical binary"), so the asymmetry was a bug.Fix
Mirror
deploy-dev.yaml's env block on the PRD api-e2e step. Same comment explaining the rationale.Test plan