fix: inline math parsing — use GitHub/pandoc dollar sign rules - #103
Merged
Merged
Conversation
Replace the opening-side currency heuristic (reject $ followed by digit)
with the standard closing-side rules used by GitHub and pandoc:
1. Opening $ must not be followed by whitespace
2. Closing $ must not be preceded by whitespace
3. Closing $ must not be followed by a digit
This correctly handles both currency ($1,200) and math starting with
digits ($2^{31}$, $1$) without false positives.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the opening-side currency heuristic (reject $ followed by digit) with the standard closing-side rules used by GitHub and pandoc:
This correctly handles both currency ($1,200) and math starting with digits ($2^{31}$ , $1$ ) without false positives.
Before:
$2^{31} \equiv 1 \pmod{P}$was rejected because the old heuristic treated any $+digit as currency.After: Parsed correctly as LaTeX math, matching GitHub's behavior.