fix(ci): correct 'make manifests' typo in check-crds-sync error message#287
Merged
whg517 merged 1 commit intoMay 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the guidance in CI workflow failure messages for the CRD sync check so it matches the actual Makefile target (manifests) used to generate CRDs.
Changes:
- Update
check-crds-syncerror message in release workflow to saymake manifests. - Update
check-crds-syncerror message in chart lint/test workflow to saymake manifests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Fixes CRD-sync failure message to reference the correct Makefile target (manifests). |
| .github/workflows/chart-lint-test.yml | Fixes CRD-sync failure message to reference the correct Makefile target (manifests). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The error message in check-crds-sync step says
make manifest(no s) but the actual Makefile target ismake manifests(with s).Changes
Fix the typo in both:
.github/workflows/chart-lint-test.yml.github/workflows/release.yml