fix(ci): add changed guard and ct setup to chart-e2e job#289
Open
whg517 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the chart-e2e GitHub Actions job to avoid running chart end-to-end tests when no Helm chart changes are present, aligning CI cost with actual chart modifications.
Changes:
- Add full git history checkout (
fetch-depth: 0) soct list-changedcan diff correctly. - Install Helm + chart-testing dependencies (Helm, Python,
helm/chart-testing-action) in thechart-e2ejob. - Gate Go setup and
make chart-e2ebehind act list-changedresult.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Run chart-testing (list-changed) | ||
| id: list-changed | ||
| run: | | ||
| changed=$(ct list-changed --chart-dirs deploy/helm --target-branch ${{ github.event.repository.default_branch }}) |
Comment on lines
+128
to
+132
| - name: Setup Chart Linting | ||
| id: lint | ||
| uses: helm/chart-testing-action@v2.8.0 | ||
|
|
||
| - name: Run chart-testing (list-changed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chart-e2e currently runs on every PR regardless of chart changes. Add ct list-changed guard, helm/ct installation steps, and if conditions to skip e2e when chart is unchanged.