ci: build vendored C++ across GCC 13/14/15 and clang#6
Open
dannywillems wants to merge 1 commit into
Open
Conversation
7251024 to
30e8c81
Compare
30e8c81 to
4bdede5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra's vendored C++ crates (
zebra-script,librocksdb-sys) can break onspecific C++ toolchains. GCC 15+ in particular fails to compile the vendored
headers that rely on transitive
<cstdint>inclusion. There is currently no CIcoverage that confirms the workspace builds across the C++ compilers users are
likely to have.
Solution
Add a CI workflow that builds the vendored C++ crates against a matrix of
toolchains in pinned containers:
gcc:13,gcc:14,gcc:15silkeh/clang:latest)Each matrix entry sets
CC/CXXso thecccrate uses the right compiler,installs the build deps, and runs
cargo build -p zebra-script(which alsocompiles
librocksdb-sysfrom source).fail-fast: falsekeeps every toolchainreporting independently.
Test evidence
Workflow runs on this PR; green across all four matrix legs confirms the
vendored C++ builds on each toolchain.
AI disclosure
Used Claude Code to author the workflow file.