Fix Copy equality/hashCode contract - #142
Open
DragonFSKY wants to merge 1 commit into
Open
DragonFSKY wants to merge 1 commit into
DragonFSKY wants to merge 1 commit into
Conversation
DragonFSKY
force-pushed
the
fix-copy-equals-hashcode-contract
branch
from
June 29, 2026 15:06
cd552b1 to
1952817
Compare
DragonFSKY
force-pushed
the
fix-copy-equals-hashcode-contract
branch
3 times, most recently
from
August 26, 2026 05:36
5759dae to
f0a8fd4
Compare
DragonFSKY
force-pushed
the
fix-copy-equals-hashcode-contract
branch
from
August 26, 2026 05:40
f0a8fd4 to
c92e507
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.
Copy.hashCode()already uses wallet identity, whileequals()previously used score ordering. Aligningequals()with the wallet keeps the equality and hash-code contract without changing score-based sorting.One regression test covers different wallets with the same score, which failed on the previous implementation.
Verification:
mvn --errors --batch-mode clean install -Pqulice(JDK 21; 69 tests, 0 failures)