Skip to content

Typo "criterias" in lib/zold/wts.rb line 140 breaks the typos CI step #63

Open

Description

@edmoffo

The YARD comment above Zold::WTS#find at lib/zold/wts.rb:140 reads "All criterias are regular expressions". criterias is not an English word — the plural of criterion is already criteria, so the source carries a typo in a docstring exposed to RubyDoc and to anyone reading the SDK.

The crate-ci/typos GitHub Action picks the misspelling up on every push and exits with code 2, leaving the typos check red on master (see https://github.com/zold-io/zold-ruby-sdk/actions/runs/27216167649/job/80358119087, log line error: criterias should be criteria). The same job is red on the latest master commit 7c79029 and on every open pull request, so contributors cannot tell a real CI failure from this one.

Replace criterias with criteria on lib/zold/wts.rb:140. The grammar of the rest of the sentence still works because the original the criteria two words earlier is already the correct plural noun.

Activity

  1. edmoffo commented on Jun 11, 2026

    @edmoffo
    Author

    @yegor256 happy to clarify the location or the failing run if anything reads ambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions