-
Notifications
You must be signed in to change notification settings - Fork 42
Create subject counts on collection #4625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuenmichelle1
wants to merge
6
commits into
master
Choose a base branch
from
create-subject-counts-on-collection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8ada81e
create subjects_count counter_cache column on collections and index
yuenmichelle1 785ca57
Update structure.sql
yuenmichelle1 4a14f94
hound sniffs use single quote and newline
yuenmichelle1 6978cc2
Merge branch 'master' into create-subject-counts-on-collection
yuenmichelle1 c3fc4d3
hound sniffs align methods
yuenmichelle1 7e13f0e
Update collections.rake
yuenmichelle1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
db/migrate/20260520193213_add_subjects_count_to_collections.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| class AddSubjectsCountToCollections < ActiveRecord::Migration[7.2] | ||
| disable_ddl_transaction! | ||
|
|
||
| def change | ||
| add_column :collections, :subjects_count, :integer, default: 0 | ||
| add_index :collections, :subjects_count, algorithm: :concurrently | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| namespace :collections do | ||
|
yuenmichelle1 marked this conversation as resolved.
|
||
| desc 'Backfill subjects_count on collections' | ||
| task backfill_subjects_count: :environment do | ||
| Collection.in_batches(of: 1_000) do |batch| | ||
| collection_ids = batch.pluck(:id) | ||
|
|
||
| counts = CollectionSubject | ||
| .where(collection_id: collection_ids) | ||
| .group(:collection_id) | ||
| .count | ||
|
|
||
| collections_to_update = collection_ids.map do |id| | ||
| [id, counts[id] || 0] | ||
| end | ||
|
|
||
| collections_to_update.each do |id, count| | ||
| Collection.where(id: id) | ||
| .update_all(subjects_count: count) | ||
| end | ||
| end | ||
| end | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.