Expose zip file metadata for attachments where it's relevant#178
Open
tnajdek wants to merge 1 commit into
Open
Expose zip file metadata for attachments where it's relevant#178tnajdek wants to merge 1 commit into
tnajdek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will expose the zip metadata as
links.zipto allow web-library to copy and rename snapshot attachments (zotero/web-library#657). It looks like this:Without this change, the web library is unable to re-register a file copied to a group library. That's because the web library has no way to learn (nor calculate) the wrapper's MD5, filename, and byte size from the existing item JSON. The existing md5/filename describe the inner file, and
links.enclosureonly carries the proxy-view URL. We also need this to enable file renaming ability for snapshots in the web library (currently broken), albeit it will have to do a full zip-and-upload workflow.The alternative would be to add more response headers to the CORS safe list in the
?info=1response. However, that means that the web library has to run an extra request for every file it renames or copies. Since the data is already there, I've opted for an additional entry inlinksinstead.I've tested the changes locally. @dstillman If you believe this should be done differently, please let me know!