Skip to content

Fix: Safkeyring truststore bug fix in certificate-analyzer#4595

Open
hrishikesh-nalawade wants to merge 3 commits intov3.x.xfrom
hrishikesh-nalawade/GH4592/certificate-analyzer-bug
Open

Fix: Safkeyring truststore bug fix in certificate-analyzer#4595
hrishikesh-nalawade wants to merge 3 commits intov3.x.xfrom
hrishikesh-nalawade/GH4592/certificate-analyzer-bug

Conversation

@hrishikesh-nalawade
Copy link
Copy Markdown
Member

Description

When the certificate-analyser is invoked with a SAF keyring truststore path (e.g. safkeyring://ZWESMVD/ZoweKeyring, type JCERACFKS), the initTruststore() method in Stores.java always uses FileInputStream to open the truststore.

The initKeystore() method in the same class correctly checks isKeyring() and uses keyRingUrl()openStream() for SAF keyrings, but this handling was never added to initTrustore()

Linked to #4592

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: hrishikesh-nalawade <hrishikesh.nalawade.17@gmail.com>
Signed-off-by: hrishikesh-nalawade <hrishikesh.nalawade.17@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
73.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant