Add zowe version print from manifest json#179
Draft
1000TurquoisePogs wants to merge 5 commits intov3.x/stagingfrom
Draft
Add zowe version print from manifest json#1791000TurquoisePogs wants to merge 5 commits intov3.x/stagingfrom
1000TurquoisePogs wants to merge 5 commits intov3.x/stagingfrom
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
| exit(EXIT_FAILURE); | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
it does not seem possible to print our version and the zowe package version on the same line at startup because the zowe runtime dir isnt known until here.
so either we move our version print down here, which is a bit late, or this PR is rather pointless since zwe prints its own version number later anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies message ZWEL0021I to include Zowe's release version to prevent user confusion in the case that launcher does not get updated with patch-only releases.
This just uses manifest.json within the workspace. It reads it using zowe-common-c json library.