PoC for Mobile App#40
Conversation
lchudinov
force-pushed
the
feature/poc-for-mobile-app
branch
5 times, most recently
from
c33a986 to
e45deb1
Compare
Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>
lchudinov
force-pushed
the
feature/poc-for-mobile-app
branch
from
d23b61d to
217e93a
Compare
1000TurquoisePogs
left a comment
1000TurquoisePogs
left a comment
There was a problem hiding this comment.
I see that you made alternative implementations for context objects, build files, and basically made a mobile window manager in order to have the login page. Shouldnt most of this code be moved to zlux-app-manager?
| multi: true, | ||
| }, | ||
| { provide: PluginManager, useValue: CordovaResources.pluginManager }, | ||
| { provide: Angular2InjectionTokens.L10N_CONFIG, useValue: { defaultLocale: { languageCode: 'en' }, providers: [] } }, |
There was a problem hiding this comment.
Detecting language on android is probably different from how we do it in the browser, but maintaining the providers separate from the code in zlux-app-manager/virtual-desktop will cause some duplication. Can it be avoided?
| @@ -0,0 +1,84 @@ | |||
| /* | |||
There was a problem hiding this comment.
this file and many other files here seem to be an alternative window manager, as opposed to the two we currently have in zlux-app-manager/virtual-desktop/src/app/window-manager ... why dont we move the code there as a third window manager?
| @@ -0,0 +1,101 @@ | |||
| /* | |||
There was a problem hiding this comment.
this file is boilerplate that the angular apps already have. does it need to be duplicated?
| @@ -0,0 +1,48 @@ | |||
| { | |||
There was a problem hiding this comment.
this file looks like the tsconfig files seen in zlux-app-manager/virtual-desktop/plugin-config
shouldnt it be moved there so that people who want to build mobile apps can extend a default configuration?
lchudinov
force-pushed
the
feature/poc-for-mobile-app
branch
2 times, most recently
from
e45deb1 to
217e93a
Compare
|
I close this PR because I moved the code into zowe/zlux-app-manager#241 |
2 participants
Depends on: