Fix app2app bug when open in new tab#685
Draft
1000TurquoisePogs wants to merge 1 commit intov3.x/stagingfrom
Draft
Fix app2app bug when open in new tab#6851000TurquoisePogs wants to merge 1 commit intov3.x/stagingfrom
1000TurquoisePogs wants to merge 1 commit intov3.x/stagingfrom
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
|
Comment on lines
+86
to
+90
| if (location.href.indexOf('?') != -1) { | ||
| window.open(`${location.href}&pluginId=${item.plugin.basePlugin.getIdentifier()}&showLogin=true`); | ||
| } else { | ||
| window.open(`${location.href}?pluginId=${item.plugin.basePlugin.getIdentifier()}&showLogin=true`); | ||
| } |
Contributor
There was a problem hiding this comment.
For the readability purposes I would suggest to use:
let concatChar = '?';
if (location.href.indexOf('?') != -1) {
concatChar = '&';
}
window.open(`${location.href}${concatChar}pluginId=${item.plugin.basePlugin.getIdentifier()}&showLogin=true`);If you read original code, you have to focus to spot a difference between line 87/89.
Martin-Zeithaml
approved these changes
Mar 3, 2026
github-project-automation
Bot
moved this from Ready for Review
to Merge Ready
in WebUI planning board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a PR to make a test build. Do not merge yet.
A user had an issue where they couldnt use the 'open in new tab' feature of the desktop when their URL already contained some query parameters about app2app. The app2app feature was failing in that new tab.
It appears they had an invalid query parameter set where
?was seen multiple times.The line changed here may be the cause, I am not sure yet.