Skip to content

fix #1073: remove hardcoded desktop href causing navigation popup#688

Open
ajju555 wants to merge 2 commits intov3.x/stagingfrom
bugfix/fix-desktop-href-navigation-popup
Open

fix #1073: remove hardcoded desktop href causing navigation popup#688
ajju555 wants to merge 2 commits intov3.x/stagingfrom
bugfix/fix-desktop-href-navigation-popup

Conversation

@ajju555
Copy link
Copy Markdown

@ajju555 ajju555 commented Mar 10, 2026

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

@1000TurquoisePogs
Copy link
Copy Markdown
Member

Thank you for submitting this PR, it looks exactly as described prior.
I'm just going to get @struga0258 and @RamkrishnaRocket1 to do a regression test to ensure there's no unforseen consequences, but otherwise LGTM and will approve after tests.

However, please do check the DCO signoff requirements because we can't merge without that.
You can fix that simply by doing a git reset to prior commit, and then re-commiting with a -s flag. More details here: https://github.com/zowe/zlux-app-manager/pull/688/checks?check_run_id=66417080158

Signed-off-by: Arjun-Verma3 <arjun.verma3@ibm.com>
@ajju555 ajju555 force-pushed the bugfix/fix-desktop-href-navigation-popup branch from 380f5dd to d50de03 Compare March 13, 2026 13:48
@github-project-automation github-project-automation Bot moved this from Ready for Review to Merge Ready in WebUI planning board Mar 19, 2026
@sonarqubecloud
Copy link
Copy Markdown

@struga0258
Copy link
Copy Markdown
Contributor

This pr breaks the desktop for me. In the console log I'm currently getting a bunch of 404 not found errors and the desktop is just a white screen.

@1000TurquoisePogs
Copy link
Copy Markdown
Member

Hi @ajju555 as @struga0258 said, our testing revealed this approach would not work, however, #699 does something very similar and does not have the same issues, so I merged that.
When the v3.5 RC comes out next week, give that a try and see if that resolves your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Merge Ready

Development

Successfully merging this pull request may close these issues.

3 participants