WIP: Make dispatcher private objects truly private#21
Open
1000TurquoisePogs wants to merge 1 commit intozowe:v1.x/stagingfrom
Open
WIP: Make dispatcher private objects truly private#211000TurquoisePogs wants to merge 1 commit intozowe:v1.x/stagingfrom
1000TurquoisePogs wants to merge 1 commit intozowe:v1.x/stagingfrom
Conversation
…d action arrays private Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "private" keyword of typescript doesn't really make objects private at runtime. Returning an anomyous object that fulfills the shape of the interface allows for objects that were private to be omitted and kept truly private.
Some of the functions in the dispatcher object weren't in the interface, and were therefore implicitly private. Typescript complained at this and so they were made private. Anyone who was using these would have gotten a typescript type definition warning so I'm assuming people weren't.
Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com